fix: add missing managedLedgerForceRecovery broker configuration field#24672
fix: add missing managedLedgerForceRecovery broker configuration field#24672thomas-bousquet wants to merge 2 commits intoapache:masterfrom
Conversation
|
@thomas-bousquet Please add the following content to your PR description and select a checkbox: |
btw. The original description of this property isn't that great. It's missing that detail that the tradeoff of using this setting is that data is lost permanently. When there are ledger failures, there's some other underlying issue that is causing them. One potential issue that is being addressed is #24665 . My assumption is that some ledger failures, could be resolved by restarting the BookKeeper cluster or restarting Pulsar cluster when the failures are caused by invalid in-memory state. There are also other issues that might cause ledger failures. For example, BookKeeper 4.17.2 (included in Pulsar 4.0.6 release) contained a fix for a data loss issue, apache/bookkeeper#4607. |
Main Issue: #21759
PIP: #21752
Motivation
managedLedgerForceRecoveryis a broker configuration field, that can be set dynamically but it is missing when we want it to be set statically through broker configuration and applied when the application/container starts.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete